[coreboot-gerrit] New patch to review for coreboot: 83a5e5d ec/kontron/it8516e: Add sanity checks for values from nvram

[Nico Huber]

Nico Huber ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3787

-gerrit

commit 83a5e5db286f8f2e148976385f96d7012fd877ce
Author: Nico Huber 
Date:   Thu Jul 18 12:27:00 2013 +0200

ec/kontron/it8516e: Add sanity checks for values from nvram

Change-Id: Ie52d80fc8657064efdcec51c31dc9309fcc28121
    Signed-off-by: Nico Huber 
---
 src/ec/kontron/it8516e/ec.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/ec/kontron/it8516e/ec.c b/src/ec/kontron/it8516e/ec.c
index 7214121..925b7ea 100644
--- a/src/ec/kontron/it8516e/ec.c
+++ b/src/ec/kontron/it8516e/ec.c
@@ -170,6 +170,8 @@ static void it8516e_set_fan_from_options(const config_t *const config,
    	       "Setting it8516e fan%d "
    	       "control to %d%% PWM.\n",
    	       fan_idx + 1, fan_target);
+		if (fan_target > 100)		/* Constrain to 100% */
+			fan_target = 100;
    	it8516e_set_fan_pwm(fan_idx, (fan_target * 255) / 100);
    	break;
    case IT8516E_MODE_SPEED:
@@ -183,6 +185,8 @@ static void it8516e_set_fan_from_options(const config_t *const config,
    	printk(BIOS_DEBUG,
    	       "Setting it8516e fan%d control to %d C.\n",
    	       fan_idx + 1, fan_target);
+		if (fan_target > 1024)		/* Constrain to 1K */
+			fan_target = 1024;
    	it8516e_set_fan_temperature(fan_idx, fan_target * 64);

fanX_min[3] = '1' + fan_idx;