Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26133 )
Change subject: soc/intel/common/block: Move cse common functions into block/cse ......................................................................
Patch Set 38:
(2 comments)
https://review.coreboot.org/c/coreboot/+/26133/37//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/26133/37//COMMIT_MSG@17 PS37, Line 17: Build and boot CNL, ICL and TGL platform. and HECI was disabled in SMM successfully without hangs or errors?
https://review.coreboot.org/c/coreboot/+/26133/37/src/soc/intel/common/block... File src/soc/intel/common/block/cse/disable_heci.c:
https://review.coreboot.org/c/coreboot/+/26133/37/src/soc/intel/common/block... PS37, Line 54: && Shouldn't this be ||? i.e. if status is non-zero or response is non-zero then it would be a failure?