Attention is currently required from: Furquan Shaikh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49214 )
Change subject: sconfig: Emit chip config pointers for PCI devices on root bus
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/49214/comment/8ff9ef8f_919c6b55
PS4, Line 1228: DEVTREE_CONST
Although I wrote the surrounding code, I don't see a reason why the pointer
itself shouldn't be plainly `const`. I can update that later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d42e926dbfae14b889ade6dda363d8607974cae
Gerrit-Change-Number: 49214
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 17:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment