[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake/vr_config: Use lookup table by default

[Patrick Rudolph (Code Review)]

Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37598 )

Change subject: soc/intel/skylake/vr_config: Use lookup table by default
......................................................................

soc/intel/skylake/vr_config: Use lookup table by default

If the board doesn't provide VRconfig in devicetree make sure to use
the lookup table for IccMax instead of defaults for some mobile SoC.

Also use decimal values instead of hex.

Change-Id: If31063f9b483a3bbd6cc90df1c1b76b4efc66445
Signed-off-by: Patrick Rudolph 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37598
Reviewed-by: Maxim Polyakov 
Reviewed-by: Michael Niewöhner
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/skylake/vr_config.c
1 file changed, 13 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Maxim Polyakov: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/soc/intel/skylake/vr_config.c b/src/soc/intel/skylake/vr_config.c
index 54dfd31..9a4ddd8 100644
--- a/src/soc/intel/skylake/vr_config.c
+++ b/src/soc/intel/skylake/vr_config.c
@@ -31,9 +31,9 @@
    	.psi3threshold = VR_CFG_AMP(1),
    	.psi3enable = 0,
    	.psi4enable = 0,
-		.imon_slope = 0x0,
-		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(7),
+		.imon_slope = 0,
+		.imon_offset = 0,
+		.icc_max = 0,
    	.voltage_limit = 1520,
    },
    [VR_IA_CORE] = {
@@ -43,9 +43,9 @@
    	.psi3threshold = VR_CFG_AMP(1),
    	.psi3enable = 0,
    	.psi4enable = 0,
-		.imon_slope = 0x0,
-		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(34),
+		.imon_slope = 0,
+		.imon_offset = 0,
+		.icc_max = 0,
    	.voltage_limit = 1520,
    },
    [VR_GT_UNSLICED] = {
@@ -55,9 +55,9 @@
    	.psi3threshold = VR_CFG_AMP(1),
    	.psi3enable = 0,
    	.psi4enable = 0,
-		.imon_slope = 0x0,
-		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(35),
+		.imon_slope = 0,
+		.imon_offset = 0,
+		.icc_max = 0,
    	.voltage_limit = 1520,
    },
    [VR_GT_SLICED] = {
@@ -67,9 +67,9 @@
    	.psi3threshold = VR_CFG_AMP(1),
    	.psi3enable = 0,
    	.psi4enable = 0,
-		.imon_slope = 0x0,
-		.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(35),
+		.imon_slope = 0,
+		.imon_offset = 0,
+		.icc_max = 0,
    	.voltage_limit = 1520,
    },
 };
@@ -334,6 +334,7 @@
    vr_params->Psi4Enable[domain] = cfg->psi4enable;
    vr_params->ImonSlope[domain] = cfg->imon_slope;
    vr_params->ImonOffset[domain] = cfg->imon_offset;
+
    /* If board provided non-zero value, use it. */
    if (cfg->icc_max)
    	vr_params->IccMax[domain] = cfg->icc_max;