Attention is currently required from: Felix Held, Felix Singer, Lean Sheng Tan, Martin L Roth, Nico Huber.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80139?usp=email )
Change subject: util/crossgcc/buildgcc: Compile RISC-V GCC with medany
......................................................................
Patch Set 3:
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/80139/comment/d481e0e9_6118b140 :
PS1, Line 779: CFLAGS_FOR_TARGET_EXTRA
No idea why you'd want to drop libgcc?
I was under the misapprehension that we currently only use it in RISCV because I could only find the `print-libgcc-file-name` stuff in the RISCV makefiles. Seeing now that we link to it everywhere I withdraw my statement. But I also said that I want to see if it makes sense to remove it and not that I want to remove it.
(like 64-bit operations when compiling for 32-bit)
Not sure why we need libgcc for that? It doesn't seem to be depending too much on the compiler considering that we use the same library for clang.
Thanks for the clang comment. I didn't see that before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5f07ce034686dd7fec160ea76838507c0ba7fa0
Gerrit-Change-Number: 80139
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 11 Feb 2024 23:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment