31 Dec
2020
31 Dec
'20
5:11 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47962 )
Change subject: mb/system76/oryp5: Enable TAS5825M smart amp ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47962/3/src/mainboard/system76/oryp... File src/mainboard/system76/oryp5/tas5825m.c:
https://review.coreboot.org/c/coreboot/+/47962/3/src/mainboard/system76/oryp... PS3, Line 3: #define R(F) { \ Macros with flow control statements should be avoided
https://review.coreboot.org/c/coreboot/+/47962/3/src/mainboard/system76/oryp... PS3, Line 5: if (res < 0) return res; \ trailing statements should be on next line
--
To view, visit https://review.coreboot.org/c/coreboot/+/47962
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148f18ff3e754d913bdf907121b103c6de02ffc3
Gerrit-Change-Number: 47962
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Dec 2020 17:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment