Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86332?usp=email )
Change subject: mb/starlabs/*: Use a safe configurations for DRAM Sleep GPIO
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Intel doc #759603 actually contains the GPIO NF list for ADL-N, and GPP_E8 has no native functions. So if using for SLP_DRAM_N, configuring as a GPO with value 1 is correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86332?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49b8faa7f8712ad0ead22b7ccbfa6deca6046368
Gerrit-Change-Number: 86332
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Sun, 09 Feb 2025 00:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes