Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40007 )
Change subject: mb/asus/p2b{,-ls}: Get rid of power button device
......................................................................
Patch Set 2: Code-Review-1
I propose we add a a config option HAVE_ACPI_POWER_BUTTON which then changes the flag in generated FADT for all southbridges. This will need extensive boot testing though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f5b7aaf32366360de3cce58cd742651a2bb46ba
Gerrit-Change-Number: 40007
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 19 Apr 2020 22:12:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment