Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38471 )
Change subject: soc/amd/picasso: Add SMMSTORE support ......................................................................
Patch Set 1:
Patch Set 1:
Of course I'm on onboard with that idea, however I would really like to get picasso functional in the repo first and then de-duplicate. Then that way we'll have two functioning generations where we can ensure it's done properly. At the moment, I'm doing work in picasso for S3 and discovering subtle differences from stoneyridge; it seems more logical to discover any others first and de-duplicate once.
Last time I checked AMD code (fam10 and fam15 stuff), there were many generations of copied files. Personally, I would not duplicate things in the first place. With some restructuring, I'm pretty sure it's easier to not duplicate in the first place. For example, adding SMBus support for picasso could be as simple as selecting SOC_AMD_COMMON_BLOCK_SMBUS.