[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: add PcieRpAspm and PchPmPciePllSsc

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39330 )

Change subject: soc/intel/tigerlake: add PcieRpAspm and PchPmPciePllSsc
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39330/1/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params_tgl.c:

https://review.coreboot.org/c/coreboot/+/39330/1/src/soc/intel/tigerlake/fsp... 
PS1, Line 48: /* Configure Aspm */
            : 	for (int i = 0; i < ARRAY_SIZE(config->PcieRpAspm); i++)
            : 		params->PcieRpAspm[i] = config->PcieRpAspm[i];
            : 
            : 	/* Configure Spread Spectrum */
            : 	params->PchPmPciePllSsc = config->PchPmPciePllSsc;
There are some follow-up changes that get rid of these.

Also, I don't think it is correct to set params->PchPmPciePllSsc unconditionally. Its default value is 0xFF and if board does not want to override it, then it should be set to 0xFF. Same with PcieRpAspm.