Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32373 )
Change subject: rockchip: rk3399: increase memory for fit payload. ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32373/2/src/soc/rockchip/rk3399/include/soc/... File src/soc/rockchip/rk3399/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/32373/2/src/soc/rockchip/rk3399/include/soc/... PS2, Line 23: 16M
I forget exactly, but someone mentioned increasing/adding a POSTRAM_CBFS_CACHE, […]
I know there needs to be a postram cache but there should be no reason for it to be 16MB. It has nothing to do with loading FIT payloads.
Please don't change this unless there's an actual reason for it so that your patch can stay single-purpose.
https://review.coreboot.org/#/c/32373/2/src/soc/rockchip/rk3399/include/soc/... PS2, Line 24: 1100000
Unless I'm mistaken, the first parameter is an address in 'normal' dram and they're […]
Okay, fair enough, but if you don't change the postram cache you also won't need to change this.