Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40286 )
Change subject: drivers/ipmi: Implement the function for logging system event into BMC
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40286/4/src/drivers/ipmi/ipmi_ops.c
File src/drivers/ipmi/ipmi_ops.c:
https://review.coreboot.org/c/coreboot/+/40286/4/src/drivers/ipmi/ipmi_ops.c...
PS4, Line 126: unsigned char data[16];
would it be possible to define type for this data? […]
Because I union three event types, just make sure to fill the correct event type, the sel does not need to be converted, I have verified this way, it worked.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f3acb958d12c196d33d34fd5cfa0b784f403b7
Gerrit-Change-Number: 40286
Gerrit-PatchSet: 5
Gerrit-Owner: Morgan Jang
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Apr 2020 02:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment