Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/tigerlake: Add processor power limits control support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39346/4/src/soc/intel/tigerlake/cpu...
File src/soc/intel/tigerlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/39346/4/src/soc/intel/tigerlake/cpu...
PS4, Line 131: BIOS_DEBUG
Even log level INFO?
https://review.coreboot.org/c/coreboot/+/39346/4/src/soc/intel/tigerlake/cpu...
PS4, Line 161: printk(BIOS_DEBUG, "CPU PL2 = %u Watts\n", tdp_pl2 / power_unit);
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41fd95949aa2b02828aa2d13d29b962cb579904a
Gerrit-Change-Number: 39346
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 12:21:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment