Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@9 PS1, Line 9: Current code surreptitiously selected Prairie Falcon if Merlin Falcon is : selected and no Merlin Falcon binaries are available. I don't understand what you mean about Prairie Falcon being selected - you're adding it to this commit. From your changes, it sort of looks like Stoney Ridge blobs may have been used in Makefile.inc.
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@16 PS1, Line 16: only Stoneyridge is combo capable Can you elaborate why are you confident that Prairie Falcon is not combo-capable? That product is Family 15h Models 70h-7Fh, just like Stoney Ridge, and according to the PSP spec, it looks like these should support combo.
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@18 PS1, Line 18: Merlin Falcon uses the same internal CPU as Carrizo, thus it has dual memory : channel while Prairie Falcon and Stoney ridge have only one channel. This really has nothing to do with the PSP blobs, and is more of a feature definition for the APU type for a given package. I would remove it.
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@20 PS1, Line 20: one particular version of Carrizo binaries Not sure what you mean by version(s) of Carrizo binaries. Are you talking about the Bristol Ridge products?