Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38423 )
Change subject: cbfs: Add metadata cache ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38423/6/src/commonlib/bsd/cbfs_mcac... File src/commonlib/bsd/cbfs_mcache.c:
https://review.coreboot.org/c/coreboot/+/38423/6/src/commonlib/bsd/cbfs_mcac... PS6, Line 15: CBFS
What's a cbfs device? The SPI flash? The bios region? The FMAP region containing a whole CBFS? Is th […]
It's whatever is represented by cbfs_dev_t. All CBFS stuff in commonlib/bsd is based on that opaque type which can be implemented by the underlying software in a variety of ways (e.g. hooked up to SPI flash for coreboot or an image file by CBFS). It only represents the area actually used by CBFS, so on SPI flash it would only be a specific FMAP region. See the comments in cbfs_private.h (in CB:38421) for a general explanation of the cbfs_dev_t API.
(A CBFS always starts immediately with the first file, so there's always an 'LARCHIVE' file magic at the beginning. See Documentation/cbfs.txt for documentation of the CBFS layout itself which is not changed by any of these patches.)