Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48564 )
Change subject: soc/amd/cezanne: add GPIO definitions ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... File src/soc/amd/cezanne/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... PS3, Line 7: GPIO_DEVICE_DESC
nit: Is there any advantage of having a macro for this? It is used in just one place in the ACPI nod […]
i can look into refactoring this later, but for now, i try to stay close to what's done in picasso to make the refactoring easier
https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... PS3, Line 95: GPIO_0_IOMUX_PWR_BTN_L
Did you generate the list?
it started as copy of the file from picasso, but got adapter for cezanne/renoir. should i remove the comment above?
https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... PS3, Line 282: GPIO_2_EVENT
Why a special macro for GPIO_2 event?
that one is currently used in the soc's gpio.c file and will be removed in a future common refactoring. currently my priority is getting bootblock and enough of ramstage working to unblock testing for the fsp development