Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Pranava Y N has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/83707?usp=email )
Change subject: mb/google/brya/var/nova: Remove USB Type-C port setting
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/nova/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83707/comment/ec98d629_4d330920?usp... :
PS2, Line 282: register "desc" = ""USB2 Type-C Port C0 (MLB)""
: register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
: register "use_custom_pld" = "true"
: register "custom_pld" = "ACPI_PLD_TYPE_C(BACK, CENTER, ACPI_PLD_GROUP(1, 0))"
I would still call this as USB-C as per product spec […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83707?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4b4025bea41f67224ac35ff2077b1394f2c3e380
Gerrit-Change-Number: 83707
Gerrit-PatchSet: 3
Gerrit-Owner: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 01 Aug 2024 07:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com