Attention is currently required from: Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................
Patch Set 22:
(6 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74005/comment/465d8ae3_3add9fd6
PS22, Line 1219: enum fpt_partition_id id,
```
static bool send_get_boot_partition_info_cmd(enum fpt_partition_id id,
struct fw_version_resp *resp)
```
https://review.coreboot.org/c/coreboot/+/74005/comment/bc8fa21f_ed0005f9
PS22, Line 1237: HECI
CSE
https://review.coreboot.org/c/coreboot/+/74005/comment/48d8bba0_2ca714bb
PS22, Line 1246: cse
CSE
https://review.coreboot.org/c/coreboot/+/74005/comment/cc6f9b2b_0c5a6a96
PS22, Line 1248: }
nit: one new line after this ?
https://review.coreboot.org/c/coreboot/+/74005/comment/c14319e1_7fe9888c
PS22, Line 1250: cse
CSE
https://review.coreboot.org/c/coreboot/+/74005/comment/1cb3de1e_e08cec5a
PS22, Line 1252: }
nit: one new line after this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 22
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 07:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment