20 Feb
2019
20 Feb
'19
2:08 p.m.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30506 )
Change subject: sb/intel/common: Remove CAR_GLOBAL use ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30506/7/src/southbridge/intel/common/spi.c File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/30506/7/src/southbridge/intel/common/spi.c@7... PS7, Line 71: static int g_ichspi_lock = 0 Well, that was a bad idea and I have overseen this patch. The issue now is, that this driver cannot be used in romsatge as in romstage simple global variables are not allowed!
--
To view, visit https://review.coreboot.org/c/coreboot/+/30506
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c90d264d851ab4abeca07f412d43d088ad96dc
Gerrit-Change-Number: 30506
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 13:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment