Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Ivy Jian has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/85975?usp=email )
Change subject: [WIP]mb/google/nissa/var/dirks: Add GPIO table
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File src/mainboard/google/brya/variants/dirks/gpio.c:
https://review.coreboot.org/c/coreboot/+/85975/comment/241a83d6_76ff4999?usp... :
PS1, Line 5: #include <commonlib/helpers.h>
no need?
no need, removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85975?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e3bc60a1c749b65c542a74eb6167e921ef369f2
Gerrit-Change-Number: 85975
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 15 Jan 2025 03:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com