Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Arthur Heymans, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63167 )
Change subject: soc/intel/alderlake: Disable FSP debug output if !HAVE_FSP_DEBUG ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/63167/comment/40d0175f_8a03889b PS2, Line 378: m_cfg->PcdSerialDebugLevel = 0;
Should this move to if (CONFIG(FSP_USES_CB_DEBUG_EVENT_HANDLER)) {} else {}?
on ADL platform, we have selected `FSP_USES_CB_DEBUG_EVENT_HANDLER` Kconfig hence, the else (that you have mentioned) doesn't make sense in SoC code.
Also, if someone remove `FSP_USES_CB_DEBUG_EVENT_HANDLER` Kconfig selection meaning, that user is wished to avoid having a debug handler in coreboot and want to relying on FSP debug library, in that case let FSP default debug level take effect.
This patch is intended to disable any FSP debug output with non-serial coreboot image (!CONFIG_SERIAL and !HAVE_FSP_DEBUG).