build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32997 )
Change subject: soc/intel/braswell: Don't use CAR_GLOBAL ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/32997/1/src/soc/intel/braswell/romstage/roms... File src/soc/intel/braswell/romstage/romstage.c:
https://review.coreboot.org/#/c/32997/1/src/soc/intel/braswell/romstage/roms... PS1, Line 132: power_state.gen_pmcon1 = read32((void *)(PMC_BASE_ADDRESS + GEN_PMCON1)); line over 80 characters
https://review.coreboot.org/#/c/32997/1/src/soc/intel/braswell/romstage/roms... PS1, Line 133: power_state.gen_pmcon2 = read32((void *)(PMC_BASE_ADDRESS + GEN_PMCON2)); line over 80 characters
https://review.coreboot.org/#/c/32997/1/src/soc/intel/braswell/romstage/roms... PS1, Line 142: power_state.prsts, power_state.gen_pmcon1, power_state.gen_pmcon2); line over 80 characters
https://review.coreboot.org/#/c/32997/1/src/soc/intel/braswell/romstage/roms... PS1, Line 143: printk(BIOS_DEBUG, "prev_sleep_state %d\n", power_state.prev_sleep_state); line over 80 characters