Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45193 )
Change subject: mb/google/octopus/variants/fleex: support LTE power sequence ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45193/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/45193/2/src/mainboard/google/octopu... PS2, Line 9: struct gpio_with_delay { : gpio_t gpio; : unsigned int delay_msecs; : }; : : static void power_off_lte_module(u8 slp_typ) : { : const struct gpio_with_delay lte_power_off_gpios[] = { : { : GPIO_161, /* AVS_I2S1_MCLK -- PLT_RST_LTE_L */ : 30, : }, : { : GPIO_117, /* PCIE_WAKE1_B -- FULL_CARD_POWER_OFF */ : 100 : }, : { : GPIO_67, /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */ : 0 : } : }; : : for (int i = 0; i < ARRAY_SIZE(lte_power_off_gpios); i++) { : gpio_output(lte_power_off_gpios[i].gpio, 0); : mdelay(lte_power_off_gpios[i].delay_msecs); : } : } The exact same power-off sequence is implemented for bobba variant. Probably it is better to move power_off_lte_module to a common source file (probably mainboard.c) and just call it here as well as for bobba.