Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32443 )
Change subject: mb/ocp/monolake: add TPM and IPMI support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32443/3/src/mainboard/ocp/monolake/mainboard...
File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/#/c/32443/3/src/mainboard/ocp/monolake/mainboard...
PS3, Line 62: res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
16, as LPC_GEN2_DEC >> 16 = 0x0c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia975643064075f1f861f4ead6f24ed71f345ea04
Gerrit-Change-Number: 32443
Gerrit-PatchSet: 3
Gerrit-Owner: Łukasz Siudut
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-Comment-Date: Wed, 24 Apr 2019 15:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment