Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46034 )
Change subject: drivers/wifi/generic: Add support for generating SMBIOS data ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge... File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/46034/1/src/drivers/wifi/generic/ge... PS1, Line 248: smbios_write_intel_wifi I am not really sure if this is still required. It was added ~6 years back(https://review.coreboot.org/c/coreboot/+/7295), but I don't see anything using this in Linux kernel. I have kept this as is for now to keep differences to a minimum from the intel wifi driver. But if this is not required, I think we should just drop it completely.