Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44723 )
Change subject: soc/mediatek/mt8192: set dramc dqsosc shuffle setting ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44723/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44723/6//COMMIT_MSG@8 PS6, Line 8: Please elaborate, and where the settings are documented.
https://review.coreboot.org/c/coreboot/+/44723/6/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44723/6/src/soc/mediatek/mt8192/dra... PS6, Line 2795: timeout Please add the unit.
https://review.coreboot.org/c/coreboot/+/44723/6/src/soc/mediatek/mt8192/dra... PS6, Line 2816: dramc_err("ZQCAL Start fail (time out)\n"); time out after %u us.