Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32356 )
Change subject: drivers/usb/ucsi: Add driver to generate UCSI memory region ......................................................................
Patch Set 1:
(1 comment)
I'm struggling to see why you made the cut between generated and static ASL code where you made it. It all depends on the CBMEM address, right? Wouldn't it be enough to generate a named object, e.g.
Name (CBMU, 0x...)
and use that in static code like
OperationRegion (UCSM, SystemMemory, CBMU, UCSI_SIZE)
and something similar for _CRS, etc.
https://review.coreboot.org/#/c/32356/1/src/drivers/usb/ucsi/ucsi.c File src/drivers/usb/ucsi/ucsi.c:
https://review.coreboot.org/#/c/32356/1/src/drivers/usb/ucsi/ucsi.c@85 PS1, Line 85: static void ucsi_fill_ssdt_generator(struct device *dev) I guess, if we'd made this more a library function that is called from EC code, we wouldn't need the `path` setting in the dt?
your call