Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36857 )
Change subject: src: Ignore Redundant offset remarks in ASL code
......................................................................
Patch Set 4:
Note that this redundancy is neither a warning nor an error. it is just a remark.
So we also can keep using them.
You all are right, this redundancy isn't a problem and can stay there. I uploaded a new patchset that adds this remark to the list of remarks that are ignored. By doing this we can get a clean output and don't have to look at remarks we don't intend to handle anyhow.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8507d3b3cb6f2e75cb87cd3e4bcc4280df27f77
Gerrit-Change-Number: 36857
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 Nov 2019 09:04:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment