Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31510 )
Change subject: AGESA binaryPI: Sync STRUCT_NAME definitions ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31510/3/src/vendorcode/amd/pi/00660F01/AMD.h File src/vendorcode/amd/pi/00660F01/AMD.h:
https://review.coreboot.org/#/c/31510/3/src/vendorcode/amd/pi/00660F01/AMD.h... PS3, Line 129: /* When AMD rolled out CarrizoPI, they made a bad choice of removing : * an entry from the middle of the enumeration list. : */
If I understand the history correctly, AmdS3Save was deprecated in favor of AmdInitRtb. […]
Simply not supporting it is one thing, dropping it from the list of enumerations within the same major revision of AGESA spec another.
A related struct was also renamed from AMD_S3_PARAMS to S3_DATA_BLOCK, although that made some sense for symmetry.