Attention is currently required from: Martin Roth. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed ......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/9fd2a7f6_87fc0c00 PS2, Line 25: spi_speed_offset Can this be offset be defined as a config item i.e. CONFIG_EFS_SPI_SPEED_OFFSET with default as -1.
Then this offset can be configured for individual SOCs. That way we can avoid SOC specific check here and simplify the logic as:
if (CONFIG_EFS_SPI_SPEED_OFFSET == -1) return CONFIG_EFS_SPI_SPEED
return read8((uint8_t *)(EVS_ADDRESS + CONFIG_EFS_SPI_SPEED_OFFSET));