Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46798 )
Change subject: soc/intel/broadwell: Clean up headers ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46798/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46798/10//COMMIT_MSG@11 PS10, Line 11: Tested with BUILD_TIMELESS=1, Google Buddy remains identical.
Please test all adapted variants.
That is, test all Broadwell boards. Will do (rather, make abuild do most of the job for me).
https://review.coreboot.org/c/coreboot/+/46798/10/src/soc/intel/broadwell/me... File src/soc/intel/broadwell/memmap.h:
PS10:
It's not all mem, is it?
it's not all io, is it?
In any case, I plan on getting rid of at least the SMBus I/O BAR definitions in future patches. I should mention it in the commit message.