Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Reka Norman, Tyler Wang, Nick Vaccaro, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 )
Change subject: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164361):
https://review.coreboot.org/c/coreboot/+/69693/comment/5766aaae_0371cc5a
PS8, Line 11: 2. Modfiy fw_config gpio table to skip the LTE and WFC setting from craask.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164361):
https://review.coreboot.org/c/coreboot/+/69693/comment/2381da8f_62ef7ff9
PS8, Line 11: 2. Modfiy fw_config gpio table to skip the LTE and WFC setting from craask.
'Modfiy' may be misspelled - perhaps 'Modify'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164361):
https://review.coreboot.org/c/coreboot/+/69693/comment/ba717621_a9f8be05
PS8, Line 14: 5. Add keybaord backligt definiation for EC
'definiation' may be misspelled - perhaps 'definition'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5
Gerrit-Change-Number: 69693
Gerrit-PatchSet: 8
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 07:29:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment