Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36130 )
Change subject: soc/intel/broadwell: Fix 'dead increment' ......................................................................
soc/intel/broadwell: Fix 'dead increment'
Dead increment spotted out using clang-tools.
Change-Id: Icfab0b9ce97722fe97a0306cb45fbc2bd072bad6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36130 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/sata.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/sata.c b/src/soc/intel/broadwell/sata.c index e47a78d..f4773e1 100644 --- a/src/soc/intel/broadwell/sata.c +++ b/src/soc/intel/broadwell/sata.c @@ -75,8 +75,7 @@ pci_write_config32(dev, 0x98, reg32);
/* Setup register 9Ch */ - reg16 = 0; /* Disable alternate ID */ - reg16 = 1 << 5; /* BWG step 12 */ + reg16 = (1 << 5); /* BWG step 12 */ pci_write_config16(dev, 0x9c, reg16);
/* SATA Initialization register */