Attention is currently required from: Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58335 )
Change subject: mb/google/kahlee/treeya/audio: use proper I2C base address define ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/kahlee/variants/treeya/audio.c:
https://review.coreboot.org/c/coreboot/+/58335/comment/dcfcb2d6_df8928e8 PS1, Line 20: do {
lol, ugh this code is hard to follow. […]
it can likely be replaced by DEV_PTR(). would also be good to add a chipset devicetree for stoneyridge, but i don't see myself getting around to look into that any time soon. a quick fix would probably be to add the alias in the mainboard's devicetree and use that. i also don't have a treeya to test, so it would be good if you or someone else form the google team can do that