[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Take ITSS polarity snaphot after GPIO configura...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31246 )

Change subject: soc/intel/cannonlake: Take ITSS polarity snaphot after GPIO configuration
......................................................................

Patch Set 2:
> > Patch Set 2:
> >
> > this should be across all soc then ?
>
> Yes, it looks like this will be required for all SoCs. I am
> wondering if we should just move snapshot/restore to
> do_silicon_init() in silicon_init.c
>
> APL/GLK is special since it calls gpio config differently than what
> KBL/CNL do. Hence, this issue was never seen on platforms using
> APL/GLK.

do_silicon_init() in silicon_init.c is in fsp driver (which is common between small and big cores) i believe then we might need to make use of common PCH Kconfig option to achieve this.