[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 )

Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................

Patch Set 50:

(1 comment)

https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/include/so...
File src/soc/intel/apollolake/include/soc/gpio_apl.h:

Line 34: 	PAD_CFG0_RXPADSTSEL_MASK | PAD_CFG0_RESET_MASK)
> What is the point of this? I didn't understand. These are the things we can

Yes and any of the bits not set here will get populated from default values. In fact, I should remove the bits that do not get set from  pad config macros. gpio_configure pad does following 
pad_conf0 = pcr_read32(comm->port, config_offset);
pad_conf0 &= ~PAD_DW0_MASK;
pcr_write32(comm->port, config_offset, pad_conf0 |
                (cfg->pad_config0 & PAD_DW0_MASK));
Same logic for pad_config1