[coreboot-gerrit] Change in coreboot[master]: console: Correct printing of hexadecimal integers

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34211 )

Change subject: console: Correct printing of hexadecimal integers
......................................................................

console: Correct printing of hexadecimal integers

Commit b19946cc62 (console: Remove support for printing extra bases)
truncated the digits string to only print integers of up to base 16.
However, that string was also used to print the leading 'x' or 'X' for
hexadecimal integers and is now too short. Fix this to prevent an out
of bounds read.

Change-Id: Iab6470cc88f445f074cf7c0b675346b37f3f2375
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1402999
---
M src/console/vtxprintf.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/34211/1

diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c
index b50f398..848ad50 100644
--- a/src/console/vtxprintf.c
+++ b/src/console/vtxprintf.c
@@ -107,7 +107,10 @@
    		call_tx('0'), count++;
    	else if (base == 16) {
    		call_tx('0'), count++;
-			call_tx(digits[33]), count++;
+			if (type & LARGE)
+				call_tx('X'), count++;
+			else
+				call_tx('x'), count++;
    	}
    }
    if (!(type & LEFT)) {