3 Apr
2023
3 Apr
'23
6:07 p.m.
Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74101 )
Change subject: mb/google/myst: Enable eSPI SCI events ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/myst/ec.c:
https://review.coreboot.org/c/coreboot/+/74101/comment/2a410106_b1352155 PS6, Line 14: GEVENT_3
Where does this value come from, since it's not specified in go/myst-gpios?
It does come from that sheet. This was errantly left in from Skyrim. There isn't an event associated with the interrupt line on Myst. I'm not sure if that's problematic.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd858c484f6fcf952bcb4f756ba2e4728091d8b
Gerrit-Change-Number: 74101
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 18:07:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment