Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35553 )
Change subject: util/mainboard/google: Fix hatch variant script ......................................................................
Patch Set 1:
(2 comments)
I'm always in favour of idempotent scripts hence the suggestion to use mkdir -p. Not sure if the script has other places where fixes would be useful to make the script idempotent.
https://review.coreboot.org/c/coreboot/+/35553/1/util/mainboard/google/hatch... File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35553/1/util/mainboard/google/hatch... PS1, Line 56: mkdir Use mkdir -p
https://review.coreboot.org/c/coreboot/+/35553/1/util/mainboard/google/hatch... PS1, Line 57: - Use cp -pr "$(SRC)/template/."
Using a wildcard will miss any dot files, and -p will preserve any exec bits. Using '-v' is perhaps not necessary IMHO, since my own preference is to avoid noisy scripts. It would be nice if there was a verbose flag that could be passed, but often sh -x is used to provide a trace of what happens anyway.