Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38123 )
Change subject: drivers/intel/fsp1_1/logo.c: Correct check for logo_size ......................................................................
drivers/intel/fsp1_1/logo.c: Correct check for logo_size
The check to validate if the logo file was loaded correctly was incorrect.
Now check the actual logo size.
BUG=N/A TEST=build
Change-Id: I4df2076b2f0cc371848a912c622268dfec24e2ef Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38123 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/drivers/intel/fsp1_1/logo.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_1/logo.c b/src/drivers/intel/fsp1_1/logo.c index 23aad01..b00406d 100644 --- a/src/drivers/intel/fsp1_1/logo.c +++ b/src/drivers/intel/fsp1_1/logo.c @@ -26,7 +26,7 @@ if (logo_buffer) { *logo_size = cbfs_boot_load_file("logo.bmp", (void *)logo_buffer, 1 * MiB, CBFS_TYPE_RAW); - if (logo_size) + if (*logo_size) *logo_ptr = (UINT32)logo_buffer; } }