5 Sep
2019
5 Sep
'19
8:24 a.m.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34743 )
Change subject: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/... PS1, Line 37: 13000
How did you arrive to 13W for PowerLimitMaximum ? Shouldn't this to 15W ?
Please, address this above comment. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34743
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a96c33ce710c32b57e2ad8066830ff83398c57
Gerrit-Change-Number: 34743
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Sep 2019 06:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment