Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45832 )
Change subject: tgl/usb: disable TBT if hardware is not USB4
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45832/1/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45832/1/src/soc/intel/tigerlake/rom...
PS1, Line 120: usb4_device
Can you add a comment here that we need to probe manually since the devicetree probing isn't determined until ramstage? (took me a minute to realize and I should know better...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07d5c416c79c40e9f85d721930549cf3374d327c
Gerrit-Change-Number: 45832
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 21:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment