Attention is currently required from: Kevin Keijzer. Hello Kevin Keijzer,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/51123
to review the following change.
Change subject: mb/lenovo/x200: Try to do something similar to CB:39708 on the X200 ......................................................................
mb/lenovo/x200: Try to do something similar to CB:39708 on the X200
The X200 would undock itself when waking up from S3, requiring a physical reconnection before the dock would work again. This should fix the regression the X201 and T410 also suffered from for the X200.
Change-Id: Icb6dd145e56b90e0e04133810c5e9ac7b641ad68 Signed-off-by: Kevin Keijzer kevin@quietlife.nl --- M src/mainboard/lenovo/x200/mainboard.c M src/mainboard/lenovo/x200/variants/x200/dock.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/51123/1
diff --git a/src/mainboard/lenovo/x200/mainboard.c b/src/mainboard/lenovo/x200/mainboard.c index 76433e8..1337035 100644 --- a/src/mainboard/lenovo/x200/mainboard.c +++ b/src/mainboard/lenovo/x200/mainboard.c @@ -17,8 +17,7 @@ GMA_INT15_BOOT_DISPLAY_DEFAULT, 2);
dev->ops->acpi_fill_ssdt = fill_ssdt; - if (CONFIG(BOARD_LENOVO_X200)) - init_dock(); + if (CONFIG(BOARD_LENOVO_X200)); }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/lenovo/x200/variants/x200/dock.c b/src/mainboard/lenovo/x200/variants/x200/dock.c index bee5441..ff787ec 100644 --- a/src/mainboard/lenovo/x200/variants/x200/dock.c +++ b/src/mainboard/lenovo/x200/variants/x200/dock.c @@ -8,13 +8,14 @@
#include "../../dock.h"
-void init_dock(void) +void h8_mb_init(void) { if (dock_present()) { printk(BIOS_DEBUG, "dock is connected\n"); dock_connect(); - } else + } else { printk(BIOS_DEBUG, "dock is not connected\n"); + } }
void dock_connect(void)