Attention is currently required from: Arthur Heymans, Felix Singer, Kapil Porwal, Meera Ravindranath, Paul Menzel, Sridhar Siricilla, Subrata Banik, Tarun Tuli.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75663?usp=email )
Change subject: vendorcode/intel: Add edk2-stable202302 support
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75663/comment/06fc5323_5c5e8c85 :
PS4, Line 10: defination
definition
Done
Patchset:
PS4:
Sorry I didn't get you. Want me to remove edk2-stable202111 support ? […]
yes, I don't think any other SoC will use 202111. let me push a patch.
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/75663/comment/c38243e2_d24eabd5 :
PS4, Line 207: #else
#endif
Done
https://review.coreboot.org/c/coreboot/+/75663/comment/58cdb3bc_a75ead87 :
PS4, Line 208: #error You need to implement this struct for x86_64 FSP
: #endif
:
For now, can we remove the "#else" part? Agreed? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d4deab0bd1d2c6df28e067894875b80413cd905
Gerrit-Change-Number: 75663
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 14 Jun 2023 04:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: comment