Attention is currently required from: Raul Rangel, Michał Żygowski, Marshall Dawson, Paul Menzel, Alexander Couzens, Patrick Rudolph, Felix Held, Piotr Król.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50592 )
Change subject: [WIP] sb,soc/amd: Move common OSFL method in ASL
......................................................................
Patch Set 2:
(1 comment)
File src/southbridge/amd/agesa/hudson/acpi/audio.asl:
https://review.coreboot.org/c/coreboot/+/50592/comment/97555fe8_61631f51
PS2, Line 37: NSDI = 1
Bits default to 0. So the change seems to disable some use of No Snoop DMA attributes.
18 NSEN EnableNoSnoopRequest.
1=Enable No Snoop request to ACPI.
0=Disable.
No snoop request to ACPI When enabled and the DMA cycle is No Snoop, ACPI will
not generate a wake to CPU in C2 state.
17 NSDO DisableNoSnoopOverride.
1=DisableNoSnoop controlling the No Snoop attribute.
0=Override DisableNoSnoop setting and always generate No Snoop attribute on
Buffer Descriptor and Data Buffer DMA.
16 NSDI DisableNoSnoop.
1=No Snoop attribute is disabled on Buffer Descriptor and Data Buffer DMA.
0=Set the No Snoop attribute on Buffer Descriptor and Data Buffer DMA when
the Traffic Priority bit is set in the Stream Descriptor.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I967b7b2afbb43253cccb4b77f6c44db45e2989e4
Gerrit-Change-Number: 50592
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 18:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment