Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee... PS1, Line 130: 1
Tested this out setting everything to the default it was already setting prior to this patch and can […]
Thanks for confirming this Brandon. I think we need one additional change. Please see my comment here: https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/fsp...
https://review.coreboot.org/c/coreboot/+/40245/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/2/src/mainboard/google/voltee... PS2, Line 129: 1 What exactly is this doing? Disabling Port1 retimer?