Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34624 )
Change subject: soc/intel/cannonlake: Clear the GPI IS & IE registers
......................................................................
Patch Set 4:
Patch Set 4: -Code-Review
Patch Set 4:
This can go into bootblock, not ramstage. We don't have any devices out in the field yet with locked R/O firmware.
make sense. may be finalize.c ?
Wouldn't it want to do this as soon as we come out of reset i.e. before any GPIOs are configured?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2185355d0095601e0778b6bf47ae137cc53e4051
Gerrit-Change-Number: 34624
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 31 Jul 2019 15:44:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment