Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add family 15h ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG@9 PS5, Line 9: Create documentation for AMD family 15h, and in particular to models for
jive? I don't understand. Sorry, English is not my first language.
It is incorrect to imply there is no coreboot code for the models I mentioned above, which is what "models for which there's coreboot code..." does. So this premise is incorrect.
This document should talk about every Family 15h model in coreboot.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 6: attend a broad spectrum
I use spell checking... but I know it does not detects everything. […]
You "attend" a party but not a spectrum of users. If you want to say attend to their needs, may be a better word is "address". But as I mentioned, I really dislike this passage.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 5: Family 15h is available in several models with different numbers of cores : and some other small variations,
True...but I have to start my document somewhere, and don't have much information to add here. […]
No, there's no relation between Family 15h vs. Family 14h. Not tick-tock, not next generation, just unrelated. Its most natural predecessor is Family 10h.
All Family 15h devices use shared resources between pairs of cores. You can search Bulldozer for more info. Each pair is called a Compute Unit or CU, and don't forget that SMT is not supported.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 12: , which all [Family 17h](family17h.md) : will also use.
Ok. Though I'm calling attention as to why I only added references to 2 models.
Since this is an "AMD Family 15h document, I think they should all be addressed.
Also, you can add source code structure, i.e. the two ST and Merlin Falcon use soc and the older ones use cpu/nb/sb.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 29: the binary PI release
Meaning I should explain it before this section?
If you expect them to understand you, then yes.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 34: >In particular,
Block quote due to problems with formatting the way I want... […]
I don't see much value in discussing what was migrated from AGESA to coreboot.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 45: References
I was intent on only the models used on recent coreboot code.
I'm only asking for links to documents.