[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add generic SMU service request

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41625 )

Change subject: soc/amd/picasso: Add generic SMU service request
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41625/3/src/soc/amd/picasso/include... 
File src/soc/amd/picasso/include/soc/smu.h:

https://review.coreboot.org/c/coreboot/+/41625/3/src/soc/amd/picasso/include... 
PS3, Line 23: uint32_t
> #include header that defines types you use. cb_err is below as well.

Done

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c 
File src/soc/amd/picasso/smu.c:

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@4... 
PS1, Line 47:
> Not sure if that's really needed in practice, but I've added it

i'd say that it's done, but needs to be tested, so i leave this one open until it's tested again