Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41427 )
Change subject: tigerlake: enable DPTF functionality for volteer
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41427/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41427/2/src/mainboard/google/voltee...
PS2, Line 167: register "power_limits_config" = "{
: .tdp_pl1_override = 15,
: .tdp_pl2_override = 60,
: }"
This is the baseboard, and just be the default for all volteer boards unless they explicitly overrid […]
even on volteer, we're building with 2 core and 4 core CPUs.
intel specifies lower PLx values for the 2 core SKU vs the
4 core SKU. i'm OK with this if there's a another patch
in the series to tune these based on run-time CPU specs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385fb409ccd291d97369295ff99f21c9430880f9
Gerrit-Change-Number: 41427
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 May 2020 23:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment